Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the release workflow to align the tag name used in CI with the version in package.json by stripping a leading v.
- Adjusts the version comparison in the release job to remove a leading
vfrom the Git tag - Ensures package.json version and Git tag match correctly when tags include a
vprefix
Comments suppressed due to low confidence (1)
.github/workflows/release.yml:35
- [nitpick] Consider adding a comment above this line to explain that the leading 'v' is stripped from the tag name so it matches the semver version in package.json.
if [[ $(jq -r .version package.json) != "${GITHUB_REF_NAME#v}" ]]; then
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.